splash: dial the backend that is actually running - #8
Merged
Conversation
The boot screen printed "ATDT 1-800-CLAUDE" on every session, codex included. It survived two sweeps that were looking straight at it, because both grepped for [Cc]laude and the string is all caps. The lesson is in the test: a sweep for a name has to be case-insensitive, or the one SHOUTED mention is exactly the one it cannot see. The line joins the rest of the copy that names the agent, in agentname.go, so there is still one place to change and a third backend gets it for free.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The boot screen printed
ATDT 1-800-CLAUDEon every session, codex included.Why two sweeps missed it
Both grepped for
[Cc]laude. The string is all caps, so the pattern could not match it — the one SHOUTED mention in the program was precisely the one a case-sensitive sweep cannot see. Redone case-insensitively across every string literal, this was the only remaining hit.The lesson is written into the test rather than a comment nobody re-reads.
Fix
The line joins the rest of the agent-named copy in
agentname.go, so there is still one place to change and a third backend gets it for free.ATDTis the Hayes modem dial command, so the joke survives — it just dials the right number now.Verified
go vet, full suite. Two tests: the helper per backend, and that the rendered splash actually contains the line, so the helper cannot drift from what is drawn.